ci(workflow): ensure relative_url is used #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
force-pushed
the
ci/workflow/ensure-relative_url-is-used
branch
from
db09647
to
df71f8d
Compare
|
How can I reproduce the issue that you were having? |
|
I understand this now, thanks! |
JiananAlvin
pushed a commit
to JiananAlvin/CLIP_exp_viz
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI build does not respect the
relative_urlproperty when building from a "project" repo instead of the.github.ionamed repo.Fixes #1373
The changes are derived from the examples here (https:/actions/jekyll-build-pages) and were tested here (ReenigneArcher#3). A small bug was found where those changes would not run certain plugins, such as those in a
_pluginsdirectory, so I reverted some of the changes, and made some tweaks in ReenigneArcher#4. The changes in this repo are slightly different than from those two PRs, as the the deploy step is omitted.The majority of people using beautiful-jekyll will probably never notice this issue because they are probably either using the repo named
.github.ioor are not using the workflow to build and deploy the pages.Evidence of functionality: https://reenignearcher.github.io/beautiful-jekyll/ (I am deploying from the CI workflow, not from a branch) https:/ReenigneArcher/beautiful-jekyll/actions/runs/10823491697