Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Refactor: use the model_info to tell us what is a relation rather than seeing if its a dictionary #14

Open
pmg103 opened this issue Oct 17, 2019 · 0 comments
Open

Refactor: use the model_info to tell us what is a relation rather than seeing if its a dictionary #14

pmg103 opened this issue Oct 17, 2019 · 0 comments
Labels
refactor Improve code structure

Comments

@pmg103
Copy link
Contributor

pmg103 commented Oct 17, 2019

It would be nicer to iterate through the same thing in both serializer and prefetcher which could also check that all the keys mentioned in the serializerspec were in fact fields/relations on the model and provide helpful error messages if not.

We should use the model_info to tell us what is a relation rather than seeing if its a dictionary
@pmg103 pmg103 added the refactor Improve code structure label Oct 17, 2019
@pmg103 pmg103 changed the title Refactor: Refactor: use the model_info to tell us what is a relation rather than seeing if its a dictionary Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor Improve code structure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmg103