-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect explanation of Unsafe usages #91
Comments
I think a good point is being raised here. I am not sure whether the documentation changed in the meantime, or whether I missed something last time. However, we could update the comment with new argumentation following the current requirements for volatile reads: |
IIUC it's bad to mix volatile and non-volatile operations. The current implementation seems to be built on a non-volatile read (to load the user-provided It seems like it would be better to use Some other options include |
subtle/src/lib.rs
Line 223 in b4b070c
The text was updated successfully, but these errors were encountered: