Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 18 - Opening Video player changes theme to black, and can't be switched afterwards #2373

Closed
Tracked by #2371
jb55 opened this issue Aug 8, 2024 · 6 comments
Closed
Tracked by #2371

Comments

@jb55
Copy link
Collaborator

jb55 commented Aug 8, 2024

No description provided.

@alltheseas
Copy link
Collaborator

alltheseas commented Sep 11, 2024

Jack reported dark mode during day randomly. Unclear if Jack is using the video player at this time.

I suspect Jack is on iOS 18 beta.

https://damus.io/note1teu2tgvluv4p3q2hme2axd73jqcsu75xnl6xncfuz3rrfga72f3q6eggec

@alltheseas
Copy link
Collaborator

@cr0bar to investigate

@jb55
Copy link
Collaborator Author

jb55 commented Sep 11, 2024

this is so random. like seriously wtf ios

@jb55
Copy link
Collaborator Author

jb55 commented Sep 11, 2024

I suspect Jack is on iOS 18 beta.

he is according to internal testflight logs

cr0bar added a commit to cr0bar/damus that referenced this issue Sep 13, 2024
…'t be switched afterwards damus-io#2373

Removed line which forces preferred colour scheme to dark.
danieldaquino added a commit to danieldaquino/damus that referenced this issue Sep 19, 2024
… back on iOS 18

Removed line which forces preferred colour scheme to dark on iOS 18, and
made adjustments to the styling to maintain text legibility

Changelog-Fixed: Fixed issue where theme would be changed to black and can't be switched back on iOS 18
Closes: damus-io#2373
Co-authored-by: Daniel D’Aquino <[email protected]>
Signed-off-by: Daniel D’Aquino <[email protected]>
danieldaquino added a commit that referenced this issue Sep 19, 2024
… back on iOS 18

Removed line which forces preferred colour scheme to dark on iOS 18, and
made adjustments to the styling to maintain text legibility

Changelog-Fixed: Fixed issue where theme would be changed to black and can't be switched back on iOS 18
Closes: #2373
Co-authored-by: Daniel D’Aquino <[email protected]>
Signed-off-by: Daniel D’Aquino <[email protected]>
@danieldaquino
Copy link
Contributor

Fixed and merged to 1.10: 6fa2e8b

@danieldaquino
Copy link
Contributor

cc @jb55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants