Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long press is more sensitive #2577

Closed
Tracked by #2371
danieldaquino opened this issue Oct 7, 2024 · 5 comments
Closed
Tracked by #2371

Long press is more sensitive #2577

danieldaquino opened this issue Oct 7, 2024 · 5 comments

Comments

@danieldaquino
Copy link
Contributor

No description provided.

@danieldaquino danieldaquino mentioned this issue Oct 7, 2024
12 tasks
@jb55
Copy link
Collaborator

jb55 commented Oct 11, 2024

This is the most irritating thing about damus atm :(

@alltheseas
Copy link
Collaborator

moving from sprint 25 to 26 (starting oct 14 2024)

@danieldaquino
Copy link
Contributor Author

I may have been mistaken on the root cause here. There seems to be more SwiftUI weirdness to it than I thought. The interaction between the swipe actions and long press does not seem to be the only thing at play in this issue. Tracking down the problem

@danieldaquino
Copy link
Contributor Author

I may have been mistaken on the root cause here. There seems to be more SwiftUI weirdness to it than I thought. The interaction between the swipe actions and long press does not seem to be the only thing at play in this issue. Tracking down the problem

Nevermind, I think I found the second part of the root cause!

@danieldaquino
Copy link
Contributor Author

Fixed! Feels much better now, submitted a PR: #2590

@jb55 Please let me know if you have any questions or concerns. Thank you!

@jb55 jb55 closed this as completed in a644902 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

3 participants