Improved performance addLine, suggestion #2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arate responsibilities and reduce the time it takes for lines to render
|
It is passing all the tests 👍 |
|
Thanks for the changes. I have created a new release and pushed to npm v0.5.0. I have started the process of cleaning up the vanilla examples by removing old umd modules and replacing them with esm and Rollup for a cleaner understanding of the code especially for debugging and benchmarking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing the shaders for the lines in WebglBaseLine to better separate responsibilities and reduce the time it takes for lines to render.