Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing diff window does not reliably terminate webdiff command #66

Open
danvk opened this issue Nov 13, 2014 · 2 comments · May be fixed by #223
Open

Closing diff window does not reliably terminate webdiff command #66

danvk opened this issue Nov 13, 2014 · 2 comments · May be fixed by #223
Labels
bug
Milestone
1.3.0

Comments

@danvk
Copy link
Owner

danvk commented Nov 13, 2014

Here's an example session:

$ webdiff https:/hammerlab/cycledash/pull/200/files
Loading pull request hammerlab/cycledash#200 from github...
  __tests__/pdifftests/examine-charted.png...
  __tests__/pdifftests/examine-sorted.png...
  __tests__/pdifftests/examine-tooltip.png...
  __tests__/pdifftests/examine.png...
Serving diffs on http://localhost:51234
Close the browser tab or hit Ctrl-C when you're done.
----------------------------------------
Exception happened during processing of request from ('127.0.0.1', 51342)
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.6_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 295, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/local/Cellar/python/2.7.6_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 321, in process_request
    self.finish_request(request, client_address)
  File "/usr/local/Cellar/python/2.7.6_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 334, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/local/Cellar/python/2.7.6_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 651, in __init__
    self.finish()
  File "/usr/local/Cellar/python/2.7.6_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 710, in finish
    self.wfile.close()
  File "/usr/local/Cellar/python/2.7.6_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 279, in close
    self.flush()
  File "/usr/local/Cellar/python/2.7.6_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 303, in flush
    self._sock.sendall(view[write_offset:write_offset+buffer_size])
error: [Errno 32] Broken pipe
----------------------------------------

^C%
@danvk danvk added the bug label Nov 13, 2014
@danvk danvk mentioned this issue Nov 7, 2016
Merged
@danvk
Copy link
Owner Author

danvk commented Jun 4, 2024

I really hope this is fixed.

@danvk danvk closed this as completed Jun 4, 2024
@danvk
Copy link
Owner Author

danvk commented Jun 5, 2024

Alas, it is not! My theory is that the beforeunload event doesn't always fire, so the server doesn't always get a shutdown notice. Maybe maintaining a websocket would work better?

@danvk danvk reopened this Jun 5, 2024
@danvk danvk changed the title Closing diff window sometimes logs stack trace Closing diff window does not reliably terminate webdiff command Jun 5, 2024
@danvk danvk modified the milestones: 1.2.0, 1.3.0 Jun 8, 2024
This was referenced Jul 15, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Use websockets to detect tab close danvk/webdiff
1 participant
@danvk