-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiapp run and stop implementation for windows #1315
Merged
mukundansundar
merged 17 commits into
dapr:master
from
pravinpushkar:feat/win_multi_app_run
Aug 30, 2023
Merged
Multiapp run and stop implementation for windows #1315
mukundansundar
merged 17 commits into
dapr:master
from
pravinpushkar:feat/win_multi_app_run
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pravin Pushkar <[email protected]>
pravinpushkar
changed the title
multiapp run implementation for windos
multiapp run implementation for windows
Jun 13, 2023
Signed-off-by: Pravin Pushkar <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1315 +/- ##
=======================================
Coverage 27.53% 27.53%
=======================================
Files 39 39
Lines 3915 3915
=======================================
Hits 1078 1078
Misses 2760 2760
Partials 77 77 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
pravinpushkar
changed the title
multiapp run implementation for windows
Multiapp run implementation for windows
Jul 7, 2023
pravinpushkar
changed the title
Multiapp run implementation for windows
Multiapp run and stop implementation for windows
Jul 10, 2023
Signed-off-by: Pravin Pushkar <[email protected]>
pravinpushkar
force-pushed
the
feat/win_multi_app_run
branch
from
August 10, 2023 08:54
f8cf1e7
to
0cce83c
Compare
shubham1172
reviewed
Aug 22, 2023
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
mukundansundar
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm. contingent on E2E passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dapr stop -f <run_template_path>
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close:
#1220
#1221
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: