Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiapp run and stop implementation for windows #1315

Merged
merged 17 commits into from
Aug 30, 2023

Conversation

pravinpushkar
Copy link
Contributor

@pravinpushkar pravinpushkar commented Jun 13, 2023

Description

  • Support Multi app run on windows
  • Support dapr stop -f <run_template_path>

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close:
#1220
#1221

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Pravin Pushkar <[email protected]>
@pravinpushkar pravinpushkar changed the title multiapp run implementation for windos multiapp run implementation for windows Jun 13, 2023
Signed-off-by: Pravin Pushkar <[email protected]>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (60f50e3) 27.53% compared to head (1bf8ec4) 27.53%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   27.53%   27.53%           
=======================================
  Files          39       39           
  Lines        3915     3915           
=======================================
  Hits         1078     1078           
  Misses       2760     2760           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
@pravinpushkar pravinpushkar changed the title multiapp run implementation for windows Multiapp run implementation for windows Jul 7, 2023
@pravinpushkar pravinpushkar marked this pull request as ready for review July 7, 2023 16:38
@pravinpushkar pravinpushkar requested review from a team as code owners July 7, 2023 16:38
@pravinpushkar pravinpushkar changed the title Multiapp run implementation for windows Multiapp run and stop implementation for windows Jul 10, 2023
cmd/run.go Outdated Show resolved Hide resolved
pkg/standalone/stop_windows.go Outdated Show resolved Hide resolved
pkg/syscall/syscall_windows.go Show resolved Hide resolved
Copy link
Collaborator

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm. contingent on E2E passing.

@mukundansundar mukundansundar merged commit 6738eef into dapr:master Aug 30, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants