Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health and metrics port mapping for placement stand-alone mode #1323

Conversation

antontroshin
Copy link
Contributor

Description

Expose healthz and metrics ports when running self-hosted with docker.
Map healthz to 58080, and metrics to 59090, to keep 5xxxx port pattern and keep 8080 and 9090 port numbers which are easier to remember what these ports are mapped to.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #800

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@antontroshin antontroshin requested review from a team as code owners June 23, 2023 20:00
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #1323 (633ab2c) into master (650fd6f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   27.55%   27.53%   -0.03%     
==========================================
  Files          39       39              
  Lines        3912     3915       +3     
==========================================
  Hits         1078     1078              
- Misses       2757     2760       +3     
  Partials       77       77              
Files Changed Coverage Δ
pkg/standalone/standalone.go 4.44% <0.00%> (-0.02%) ⬇️

@@ -521,6 +521,14 @@ func runPlacementService(wg *sync.WaitGroup, errorChan chan<- error, info initIn

args = append(args,
"-p", fmt.Sprintf("%v:50005", osPort))

healthPort := 58080
Copy link
Contributor

@pravinpushkar pravinpushkar Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we separate them out to a const ? also same with metrics port below.

Copy link
Contributor

@pravinpushkar pravinpushkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukundansundar mukundansundar merged commit 60f50e3 into dapr:master Aug 8, 2023
28 checks passed
@mukundansundar mukundansundar added this to the v1.12 milestone Aug 8, 2023
@antontroshin antontroshin deleted the placement_standalone_health_and_metric_ports branch August 8, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose port 8080 in Placement Service when running dapr init
4 participants