dapr_scheduler: Adds scheduler-volume flag #1422
Conversation
Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
JoshVanL
changed the title
| @@ -219,6 +224,7 @@ func init() { | |||
| InitCmd.Flags().String("network", "", "The Docker network on which to deploy the Dapr runtime") | |||
| InitCmd.Flags().StringVarP(&fromDir, "from-dir", "", "", "Use Dapr artifacts from local directory for self-hosted installation") | |||
| InitCmd.Flags().StringVarP(&imageVariant, "image-variant", "", "", "The image variant to use for the Dapr runtime, for example: mariner") | |||
| InitCmd.Flags().StringVarP(&schedulerVolume, "scheduler-volume", "", "", "Self-hosted only. Optionally specify a volume for the scheduler service data directory. By default, scheduler data is not persisted and not resilient to restarts without this flag.") | |||
There was a problem hiding this comment.
We should have a volume by default instead of not persisting stuff.
There was a problem hiding this comment.
https:/dapr/dapr/blob/7ea7016c0150e6a7b7bc7c30e34d56f0001c5e90/cmd/scheduler/options/options.go#L82
Agreed, unless the defaults are changed in both places. The mount should in its current state be created by default for the CLI 1.14.0-rc.4 release - in its current state a dapr init does not result in the scheduler running successfully.
|
@holopin-bot @JoshVanL Thanks Josh! |
|
Congratulations @JoshVanL, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8g0rc139670ck4ocz46v0b This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Expose
--scheduler-volumeto optionally specify the volume which scheduler writes to.