[WIP] Add subscriptions command to Dapr CLI #1424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantoDE
commented
Jul 15, 2024
| if err != nil { | ||
| return | ||
| } | ||
| outputList(list, len(list)) |
There was a problem hiding this comment.
Im not sure if I should reuse that here?
SantoDE
force-pushed
the
subscriptions_command
branch
from
dd881d2
to
aa2623b
Compare
SantoDE
changed the title
SantoDE
force-pushed
the
subscriptions_command
branch
from
aa2623b
to
d26e35b
Compare
Signed-off-by: Manuel Zapf <[email protected]>
SantoDE
force-pushed
the
subscriptions_command
branch
from
d26e35b
to
26c5a73
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sidecar of an application obviously knows, which PubSub its subscribed to. This command adds the possibility to the CLI to get that information cleanly, rather than manually querying the sidecar.
Issue reference
While its not an issue, reference to the discussion on Discord: here
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Since this is my first contribution to Dapr CLI, happy to learn a ton! For now this is only added for stand-alone, but I want to eventually add it to k8s as well.