Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for django 2 #657

Open
Snakeyyy opened this issue Dec 27, 2017 · 9 comments · May be fixed by #774
Open

Support for django 2 #657

Snakeyyy opened this issue Dec 27, 2017 · 9 comments · May be fixed by #774

Comments

@Snakeyyy
Copy link

Could you please provide information what are the plans for supporting django 2.0? Is suit v1 going to support it?

@scott-weaver
Copy link

scott-weaver commented Jan 2, 2018

Locally, I got it to work with 2.0 by just making the following changes:

old: from django.core.urlresolvers import reverse, resolve
new: from django.urls import reverse, resolve

old: @register.assignment_tag(takes_context=True)
new: @register.simple_tag(takes_context=True)

The only files I had to change were suit_menu.py and suit_tags.py, so hopefully it will be a quick fix.

@gamesbook
Copy link

Is there any activity at all from @darklow recently on this project?

@darklow
Copy link
Owner

darklow commented Jan 3, 2018

I'm currently very busy working on another project. If someone could take a look on existing pull requests on Django 2.0 support and test them and provide feedback I could merge them in.

@mikewolfli
Copy link

also admin.py in line 94:
if isinstance(field.rel, models.ManyToOneRel):
should change to
if isinstance(field.remote_field, models.ManyToOneRel):

@bigwboy
Copy link

bigwboy commented Jan 16, 2018

py3.6
django 2.0.1
需要调整: site-packages/suit/templatetags/tempsuit_menu.py
site-packages/suit/templatetags/suit_tags.py
site-packages/suit/templatetags/suit_forms.py

调整内容: 原有: from django.core.urlresolvers import reverse, resolve
新: from django.urls import reverse, resolve
原有: @register.assignment_tag(takes_context=True)
新: @register.simple_tag(takes_context=True)

@jayWarr
Copy link

jayWarr commented Jan 23, 2018

for python 3.6.3
django 2.0.1
suit 2.0a1

change file:
/lib/python3.6/site-packages/suit/admin.py
@ line 3:
from django.core.urls import reverse_lazy
to
from django.urls import reverse_lazy

and

change file:
/lib/python3.6/site-packages/suit/menu.py
@line 223
from django.core.urlresolvers import reverse, NoReverseMatch
to
from django.urls import reverse, NoReverseMatch

@darklow
Copy link
Owner

darklow commented Feb 24, 2018

Django 2.0 support for v1 was just added through: #663
Available though newest 0.2.26.
For v2 and Django 2.0 I need some help testing #652 (comment)
Thank you.

@darklow
Copy link
Owner

darklow commented Mar 3, 2018

PR with v2 support was merged in: #652

@jedie
Copy link

jedie commented Aug 23, 2019

PR with v2 support was merged in: #652

So this issues can be closed, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment