Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a UI to embeds to introduce the keyboard shortcuts #1134

Closed
galeyang opened this issue Jun 27, 2019 · 4 comments
Closed

Add a UI to embeds to introduce the keyboard shortcuts #1134

galeyang opened this issue Jun 27, 2019 · 4 comments
Labels
closed-duplicate Closed in favor of an existing report P2 A bug or feature request we're likely to work on type-ux A user experience or user interface related issue
Milestone
October 2019

Comments

@galeyang
Copy link

galeyang commented Jun 27, 2019 •
edited
Loading

The keyboard shortcuts are implemented here #1094
It would be great to have a place to list out these hotkeys so that they're more discoverable. This is less important in exercises but can be useful in a playground.

Examples:
Kotlin
image

Another transcription service
image
@galeyang galeyang added P2 A bug or feature request we're likely to work on type-ux A user experience or user interface related issue labels Jun 27, 2019
@RedBrogdon RedBrogdon added this to the Backlog milestone Jul 24, 2019
@RedBrogdon
Copy link
Contributor

Ideally we should have a keyboard shortcut to display the shortcuts, similar to a number of other editors.

@johnpryan johnpryan mentioned this issue Aug 15, 2019
Closed
@galeyang galeyang mentioned this issue Aug 15, 2019
Merged
@galeyang galeyang mentioned this issue Oct 4, 2019
Closed
@johnpryan johnpryan self-assigned this Oct 4, 2019
@johnpryan johnpryan modified the milestones: Backlog, October 2019 Oct 4, 2019
@jawahars16
Copy link
Contributor

@RedBrogdon Looks like this is already implemented. I can see a key bindings dialog using the shortcut shift-ctrl-/. Is there anything wrong or pending with this functionality?

@johnpryan johnpryan changed the title Add a UI to introduce the keyboard shortcuts Add a UI to embeds to introduce the keyboard shortcuts Oct 21, 2019
@johnpryan
Copy link
Contributor

johnpryan commented Oct 21, 2019 •
edited
Loading

@jawahars16 I think this issue was to track adding this dialog to the embedded editors

@parlough
Copy link
Member

Thanks for the discussion here! I'm going to close this in favor of a consolidated information menu for the embed form of the UI - #3007.

@parlough parlough closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@parlough parlough added the closed-duplicate Closed in favor of an existing report label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate Closed in favor of an existing report P2 A bug or feature request we're likely to work on type-ux A user experience or user interface related issue
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
5 participants
@RedBrogdon @johnpryan @galeyang @jawahars16 @parlough