Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General feedback on the issue triage bot #271

Open
devoncarew opened this issue Jun 14, 2024 · 16 comments
Open

General feedback on the issue triage bot #271

devoncarew opened this issue Jun 14, 2024 · 16 comments

Comments

@devoncarew
Copy link
Member

This issue is for collecting feedback on the issue triage bot; areas where it could improve, individual issues that it didn't triage well, possible prompt improvements, ...

Please feel free to create new comments here for feedback.

@parlough
Copy link
Member

parlough commented Jun 14, 2024

Issue/comment: dart-lang/sdk#56002 (comment)

Feedback: The bot triaged this macro related issue into area-test, likely because the issue discussed failing tests. As this is a common scenario, area-test should be weighted down somehow or have even more explicit prompting around preferring functional area.

@natebosch
Copy link
Member

dart-lang/sdk#56028 (comment) would benefit from getting more context than the first comment of the issue.

@devoncarew
Copy link
Member Author

devoncarew commented Jun 24, 2024

Similarly to the previous comment, for transferred issues (like dart-lang/sdk#56072), we should at least feed in the first and last comment if not all the comments.

We may also consider introducing a slight delay in triaging issues (2 min?). This would allow some time for manual triage.

@devoncarew
Copy link
Member Author

We should auto-close Analyzer Feedback from IntelliJ issues; these almost universally do not contain information (are not customized over the default template that just sends version info).

@devoncarew
Copy link
Member Author

See #274 for a few of the discussed improvements.

@devoncarew
Copy link
Member Author

When an issue comment contains an image, we should pass that image into the gemini API (along with the issue comment's text).

@FMorschel
Copy link

Maybe pass the current docs to solve cases like: dart-lang/sdk#56180? I'm not really sure what to suggest but the summary is off.

@devoncarew
Copy link
Member Author

Yeah, I agree that that summary is off; you were asking for an analyzer code assist and it summarized it as a language enhancement request. I don't know if that means we need better prompting here, and the model is already well-trained on the Dart language. Perhaps a better model? General incremental improvements in gemini's capabilities? We're using gemini-1.5-flash to classify now, I could try a dry run w/ just regular gemini 1.5.

@FMorschel
Copy link

Maybe a way to ask the bot for a review? Than you could have a little more context into the new review

@devoncarew
Copy link
Member Author

Maybe a way to ask the bot for a review? Than you could have a little more context into the new review

Do you mean to interact with the bot a bit to improve the summary? I think it would be reasonable to re-prompt it based on responses to its summary / classification comment.

@FMorschel
Copy link

Exactly. Maybe a keyword (or even pinging it) to ask for it to review the OP and the keyword comment. I believe if that is to become a thing, it should probably always appear at the end of its comments, like: "If you disagree with me, do this to make it so that I review this issue again".

@FMorschel
Copy link

Not sure what's going on here but I have the Dart SDK as a fork (intend on helping out soon). Both:

Have sent me an email with failed jobs and have not been able to place the tags correctly, only commenting.

Maybe there is a bug here? Not sure if this is the right place or if this should have been a new issue.

image

@FMorschel
Copy link

About the above comment, not sure if it has been addressed or what (maybe a tag-specific problem), but I just created a new issue dart-lang/sdk#56631. Got no email errors and the bot could place the tags normally.

@devoncarew
Copy link
Member Author

We had a regression in the triage bot - it was briefly trying to assign too many labels and the label assignment part of the workflow was failing; I suspect that's what you were seeing.

@FMorschel
Copy link

I see.

But why does the fork gets the email? I see that I have not received any other issue so only issues I wrote but still don't understand why am I receiving the emails? Is this a bug on GitHub Actions or something?

@devoncarew
Copy link
Member Author

But why does the fork gets the email? I see that I have not received any other issue so only issues I wrote

Good question! I'm not sure why you're being notified. Perhaps it's related to your fork or perhaps related to you being the author of the issue that's triggering the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants