Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firehose should add some tools to make sure people are publishing from the intended commit #308

Open
devoncarew opened this issue Oct 18, 2024 · 0 comments
Labels
package:firehose type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

Currently, firehose publishing generally publishes from the head commit. This generally happens thuswise:

  • firehose writes a publishing comment into a PR
  • that PR eventually lands
  • a contributor with commit access clicks on the 'publish' link in the PR; that opens a pre-populated release page that (when created) will trigger publishing

If there are many packages in a repo, we don't always want to publish from the latest commit; other commits may have landed after the original PR. When creating the release page info, we should add some text to encourage the user to tag a specific commit (which will frequently, but not always, be head). The commit to tag add can be selected from the 'target', 'recent commits' dropdown:

Screenshot 2024-10-18 at 11 01 56 AM
@devoncarew devoncarew added type-enhancement A request for a change that isn't a bug package:firehose labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant