Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have a way to configure publishing dry run checks #64

Open
devoncarew opened this issue Feb 9, 2023 · 2 comments
Open

have a way to configure publishing dry run checks #64

devoncarew opened this issue Feb 9, 2023 · 2 comments
Labels
package:firehose type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

Right now some packages have intentional dart pub publish --dry-run warnings. firehose fails the build on the dry-run checks; we may want some additional configurability here. See dart-lang/test#1923 for context.

Some ideas are:

  • for pub publish dry-run to support some ignore: xxx syntax in pubspec files
  • have a way for a repo to configure that dry run checks shouldn't be run for specific packages
  • have a way for firehose to distinguish dry-run warnings vs errors and not fail builds for warnings (as pub is currently, any warnings sets an exit code of 65)
@devoncarew devoncarew added type-enhancement A request for a change that isn't a bug package:firehose labels Feb 9, 2023
@jakemac53
Copy link
Contributor

Fwiw, if the ignore syntax is feasible it would be my preference. This would in general make publishing safer on packages that have known warnings (only new warnings would appear), and document those warnings that are known to exist.

@devoncarew
Copy link
Member Author

One other way we could configure this to ignore publishing warnings is by supporting something like a publishing-ignore-warnings label; that's something a repo maintainer could add to a PR if they knew the particular warnings wasn't relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants