Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename app.dart to example.dart #222

Closed
wants to merge 1 commit into from
Closed

Rename app.dart to example.dart #222

wants to merge 1 commit into from

Conversation

bcko
Copy link

@bcko bcko commented May 26, 2018

rename so that this example can show up on the pub site

https://www.dartlang.org/tools/pub/package-layout#examples

related issue : dart-lang/site-www#413

rename so that this example can show up on the pub site
@srawlins
Copy link
Member

@kevmoo will this still work with GitHub pages, and tool/update-gh-pages.sh?

@kevmoo
Copy link
Member

kevmoo commented May 29, 2018

Oh yeah. Don't care about the dart name – just 'index.html'

@kevmoo
Copy link
Member

kevmoo commented May 29, 2018

Take that back.

  1. Would need to fix reference to app.dart in index.html
  2. This is not a good example of markdown. We should likely rename this directory to be `web_playground' or something.

@kevmoo kevmoo closed this May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants