Don't try to be smart with unsupportedMembers
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
If `MockSpec` says a member is not supported, just generate a `throw`, even if it looks like we could get away without it. PiperOrigin-RevId: 531137412
srawlins
approved these changes
May 11, 2023
|
Uh.. I'm not sure it was supposed to appear here: still not submitted internally. |
|
Haha maybe just a PR to check external CI (like issues with pub package dependencies). Glad I didn't click 'Merge' 😁 |
|
Oh yes, I added that Copybara presubmit recently. But I didn't realize it's going to be a public PR for every CL I try ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to be smart with
unsupportedMembersIf
MockSpecsays a member is not supported, just generate athrow,even if it looks like we could get away without it.