This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
Handle escaped colons in Windows file:// URIs #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for dart-lang/core#545. Using
Uri().toFilePath()
handles escaped colons in drive letters, butContext.fromUri()
currently (without this PR) does not.I'm unable to find anything concrete about how valid this is, but the opinion of the LSP maintainers is that this is valid, and since the
Uri
class handles it I feel like supporting this is the best route. I don't think there are any negative consequences of supporting this.@devoncarew @kevmoo I don't know who's getting PR notifications for this repo, but since you both committed here recently perhaps you know who might be able to review this? Thanks :-)