Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Implement regression #5

Merged
merged 16 commits into from
Jan 8, 2019
Merged

Implement regression #5

merged 16 commits into from
Jan 8, 2019

Conversation

mlemainque
Copy link
Contributor

@mlemainque mlemainque commented Dec 5, 2018

This PR includes:

dask_lightgbm/core.py Outdated Show resolved Hide resolved
dask_lightgbm/core.py Outdated Show resolved Hide resolved
@mlemainque mlemainque changed the title Implement regression and scores Implement regression Jan 2, 2019
dask_lightgbm/core.py Outdated Show resolved Hide resolved
system_tests/test_fit_predict.py Outdated Show resolved Hide resolved
system_tests/test_fit_predict.py Outdated Show resolved Hide resolved
@mlemainque
Copy link
Contributor Author

mlemainque commented Jan 3, 2019

Do you have an idea how we could solve the LGBM port binding and socket transient errors?

[LightGBM] [Fatal] Socket recv error, code: 104
[LightGBM] [Fatal] Binding port XXXXX failed

They are quite frequent despite the use of different port for each tests
I almost never had this kind of error in real applications with large resources

Whatever you can re-trigger the tests and eventually they will succeed

@SfinxCZ
Copy link
Collaborator

SfinxCZ commented Jan 4, 2019

@mlemainque I've tried to investigate these errors few weeks back and the result is that there is some problem with closing the communication in the LightGBM C++ code. Unfortunately, I was not able to precisely locate where is the problem. You may try to create issue for LightGBM directly.

One solution (or more like hack) on our side is to wait for few seconds/minutes until the socket is timeouted and returned to OS or use different ports for every test (that is what I've used) or run every single test in separate docker container (ugh) since separate processes wont work.

system_tests/test_fit_predict.py Outdated Show resolved Hide resolved
@SfinxCZ SfinxCZ merged commit 15c44e7 into dask:master Jan 8, 2019
@mlemainque mlemainque deleted the develop branch January 8, 2019 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants