Pass host through LocalCluster to workers
#5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `host` parameter to `LocalCluster` would only be forwarded to `Scheduler` instances and not `Worker`/`Nanny` instances, leading to workers listening on non-localhost in some configurations. This fixes that and adds a test.
…host-to-localcluster-worker
zanieb
pushed a commit
to zanieb/distributed
that referenced
this pull request
Oct 28, 2021
Previously the `host` parameter to `LocalCluster` would only be forwarded to `Scheduler` instances and not `Worker`/`Nanny` instances, leading to workers listening on non-localhost in some configurations. This fixes that and adds a test. Co-authored-by: James Bourbeau <[email protected]>
|
Just to express thanks, I upgraded and can now confirm this potential security vulnerability is avoided as the local cluster now clearly binds to 127.0.0.1 by default. I checked 'tcp://127.0.0.1:35689'And ['tcp://127.0.0.1:35071',
'tcp://127.0.0.1:37679',
'tcp://127.0.0.1:39051',
'tcp://127.0.0.1:42149',
'tcp://127.0.0.1:42557',
'tcp://127.0.0.1:44993'] |
quasiben
pushed a commit
to quasiben/distributed
that referenced
this pull request
Nov 16, 2022
Previously the `host` parameter to `LocalCluster` would only be forwarded to `Scheduler` instances and not `Worker`/`Nanny` instances, leading to workers listening on non-localhost in some configurations. This fixes that and adds a test. Co-authored-by: James Bourbeau <[email protected]>
quasiben
pushed a commit
to quasiben/distributed
that referenced
this pull request
Nov 16, 2022
Previously the `host` parameter to `LocalCluster` would only be forwarded to `Scheduler` instances and not `Worker`/`Nanny` instances, leading to workers listening on non-localhost in some configurations. This fixes that and adds a test. Co-authored-by: James Bourbeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures
hostparameter is properly forwarded throughLocalClusterto all created objects and adds a corresponding test.pre-commit run --all-files