Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip click v8.1.4 in mypy pre-commit hook #7989

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

graingert
Copy link
Member

@graingert graingert commented Jul 12, 2023

Closes #7988

  • Tests added / passed
  • Passes pre-commit run --all-files

@graingert graingert requested a review from fjetter as a code owner July 12, 2023 13:17
@graingert
Copy link
Member Author

graingert commented Jul 12, 2023

I'm skipping 8.1.4 and allowing future versions because there's a new PR with a fix pending release that I verified works by running pre-commit with:

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 9bfd3e335..164fe2257 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -58,7 +58,7 @@ repos:
           - types-psutil
           - types-setuptools
           # Typed libraries
-          - click!=8.1.4
+          - click @ https:/Tinche/click/archive/refs/heads/tin/typing-tests.zip
           - numpy
           - pytest
           - tornado

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @graingert!

@hendrikmakait hendrikmakait merged commit 6c37907 into dask:main Jul 12, 2023
18 of 22 checks passed
@graingert graingert deleted the skip-click-8-1-4 branch July 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy failing due to click 8.1.4
2 participants