Add complex number support to linalg.cholesky
#443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
API change
This config does not seem to be needed. SymPy does not include it in its docs. Seems fine for us to omit, as well, given that it causes builds to fail.
rgommers
reviewed
May 23, 2022
leofang
approved these changes
Jun 6, 2022
|
Thanks, @leofang! As this has now been approved and follows discussions originating in the original Cholesky PR(s) (see #110, #224 (comment), and #220), will merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
linalg.cholesky, requiring that each complex-valued matrix be Hermitian.