Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add complex number support to atan #523

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add complex number support to atan #523

merged 1 commit into from
Dec 5, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 27, 2022

This PR

  • adds complex number support to atan by documenting special cases. By convention, the inverse tangent has a branch cut placed at the line segments (-infinity j, -j) and (j, infinity j) of the imaginary axis.
  • updates the input and output array data types to be any floating-point data type, not just real-valued floating-point data types.
  • derives special cases from C99

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Nov 27, 2022
@kgryte kgryte added this to the v2022 milestone Nov 27, 2022
@kgryte kgryte mentioned this pull request Nov 27, 2022
Closed
rgommers
rgommers approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte. This PR has been open for a week and the complex number basic principles (branch cuts, type promotion, etc.) have been reviewed in separate PRs already. So I'll merge this.

@rgommers rgommers merged commit 57d60ce into main Dec 5, 2022
@rgommers rgommers deleted the cmplx-atan branch December 5, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @rgommers