Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex number support to prod #553

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Add complex number support to prod #553

merged 1 commit into from
Dec 14, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 5, 2022

This PR

  • adds support for computing the product of complex numbers. As described in Add complex number support for multiplication #551, for complex numbers having finite components, complex number multiplication is well-defined; however, special cases involving NaN and infinite components may diverge depending on how one chooses to model complex infinity.
  • specifies that special cases be derived as if the operation was implemented as a reduction over multiply.
  • requires that, if x is a complex floating-point data type and dtype is None, the function must return an array having the default complex floating-point data type.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.
  • depends on Add complex number support for multiplication #551.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Dec 5, 2022
@kgryte kgryte added this to the v2022 milestone Dec 5, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR this depended on is merged now, and this LGTM - so in it goes. Thanks @kgryte

@rgommers rgommers merged commit 91656a7 into main Dec 14, 2022
@rgommers rgommers deleted the cmplx-prod branch December 14, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants