Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require axis to be negative in vecdot and cross #740

Merged
merged 1 commit into from
Feb 13, 2024

Commits on Feb 2, 2024

  1. Only require axis to be negative in vecdot and cross

    Nonnegative axes and negative axes less than the smaller of the two arrays are
    unspecified.
    
    This is because it is ambiguous in these cases whether the
    dimension should refer to the axis before or after broadcasting. Preciously,
    the spec stated it should refer to the dimension before broadcasting, but this
    deviates from NumPy gufunc behavior, and results in ambiguous and confusing
    situations, where, for instance, the result of a the function is different
    when the inputs are manually broadcasted together.
    
    Also clean up some of the cross text a little bit since the computed dimension
    must be exactly size 3.
    
    Fixes data-apis#724
    Fixes data-apis#617
    
    See the discussion in those issues for more details.
    asmeurer committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    7728c98 View commit details
    Browse the repository at this point in the history