Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new statTypes #247

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add new statTypes #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0318fc8
add new statTypes
ajaits Nov 11, 2023
6920df5
change rank statype to existing rankFromTop/Bottom
ajaits Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions util/src/main/java/org/datacommons/util/DcidGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ public class DcidGenerator {
Vocabulary.CONFIDENCE_INTERVAL_UPPER_LIMIT,
Vocabulary.KURTOSIS,
Vocabulary.SKEWNESS,
Vocabulary.VARIENCE_VALUE,
Vocabulary.PALMA_RATIO,
Vocabulary.RANK_FROM_TOP,
Vocabulary.RANK_FROM_BOTTOM,
Vocabulary.DECILE_VALUE,
Vocabulary.MEASUREMENT_DENOMINATOR,
Vocabulary.MEASUREMENT_QUALIFIER,
Vocabulary.SCALING_FACTOR);
Expand Down
10 changes: 9 additions & 1 deletion util/src/main/java/org/datacommons/util/Vocabulary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ public final class Vocabulary {
public static final String CONFIDENCE_INTERVAL_UPPER_LIMIT = "confidenceIntervalUpperLimit";
public static final String KURTOSIS = "kurtosisValue";
public static final String SKEWNESS = "skewnessValue";
public static final String VARIENCE_VALUE = "varianceValue";
public static final String PALMA_RATIO = "palmaRatio";
public static final String RANK_FROM_TOP = "rankFromTop";
public static final String RANK_FROM_BOTTOM = "rankFromBottom";
public static final String DECILE_VLUE = "decileValue";
public static final String MEASUREMENT_RESULT = "measurementResult";

// Quantity/QuantityRange props
Expand Down Expand Up @@ -333,7 +338,10 @@ public static boolean isStatValueProperty(String val) {
|| lcVal.endsWith("stderror")
|| lcVal.endsWith("samplesize")
|| lcVal.endsWith("growthrate")
|| lcVal.endsWith("limit");
|| lcVal.endsWith("limit")
|| lcVal.endsWith("palmaratio")
|| lcVal.startsWith("rank");

}

public static boolean isStatVar(String type) {
Expand Down