Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): Remove env deprecation message #10581

Merged
merged 2 commits into from
May 23, 2024
Merged

fix(ingest): Remove env deprecation message #10581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5e817a
Remove env deprecation message
treff7es May 23, 2024
b713697
Remove unneeded import
treff7es May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions metadata-ingestion/src/datahub/configuration/source_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from pydantic.fields import Field

from datahub.configuration.common import ConfigModel
from datahub.configuration.validate_field_deprecation import pydantic_field_deprecated
from datahub.metadata.schema_classes import FabricTypeClass

DEFAULT_ENV = FabricTypeClass.PROD
Expand Down Expand Up @@ -36,12 +35,6 @@ class EnvConfigMixin(ConfigModel):
description="The environment that all assets produced by this connector belong to",
)

_env_deprecation = pydantic_field_deprecated(
"env",
message="We recommend using platform_instance instead of env. "
"While specifying env does still work, we intend to deprecate it in the future.",
)

@validator("env")
def env_must_be_one_of(cls, v: str) -> str:
if v.upper() not in ALL_ENV_TYPES:
Expand Down
Loading