Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion/kafka)-Add support for ingesting schemas from schema registry #10612

Merged
merged 4 commits into from
Jun 11, 2024
Merged

feat(ingestion/kafka)-Add support for ingesting schemas from schema registry #10612

merged 4 commits into from
Jun 11, 2024

Conversation

aabharti-visa
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels May 29, 2024
@aabharti-visa aabharti-visa changed the title Add support for ingesting schemas from schema registry feat(ingestion/kafka)-Add support for ingesting schemas from schema registry May 29, 2024
@aabharti-visa
Copy link
Contributor Author

Attaching sample UI screenshots.

Screenshot 2024-05-29 at 3 07 13 PM Screenshot 2024-05-29 at 8 31 32 PM Screenshot 2024-05-29 at 8 32 39 PM

@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch from 892ec1c to 406da0c Compare May 30, 2024 12:17
@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch from e3d14de to c13679b Compare May 30, 2024 17:24
@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch from ff45fd7 to 2e9948a Compare May 31, 2024 22:54
@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch from 322df18 to 1a57f3e Compare June 3, 2024 14:34
@hsheth2 hsheth2 requested a review from treff7es June 3, 2024 16:38
@aabharti-visa
Copy link
Contributor Author

@treff7es please review. Thanks.

treff7es
treff7es reviewed Jun 5, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/confluent_schema_registry.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/confluent_schema_registry.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/confluent_schema_registry.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/kafka.py Outdated Show resolved Hide resolved
@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch from d633633 to 3bd9c18 Compare June 6, 2024 13:22
@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch 7 times, most recently from c9ae68f to df15145 Compare June 6, 2024 16:57
@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch 2 times, most recently from b2bbc0d to e480172 Compare June 6, 2024 17:58
@aabharti-visa aabharti-visa force-pushed the Add-support-for-ingesting-schemas-from-schema-registry branch from e480172 to faa2280 Compare June 6, 2024 18:30
@treff7es treff7es merged commit 8a90577 into datahub-project:master Jun 11, 2024
58 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@aabharti-visa @sleeperdeep
feat(ingestion/kafka)-Add support for ingesting schemas from schema r…
857621a 
…egistry (datahub-project#10612)
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@aabharti-visa @yoonhyejin
feat(ingestion/kafka)-Add support for ingesting schemas from schema r…
7e60401 
…egistry (#10612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabharti-visa @treff7es