Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion): schema inference for jsonlines in S3 #5725

Merged
merged 16 commits into from
Sep 12, 2022

Conversation

hieunt-itfoss
Copy link
Contributor

@hieunt-itfoss hieunt-itfoss commented Aug 25, 2022

Resolves #5603

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Aug 25, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 56s ⏱️ + 3m 7s
   692 tests ±0     689 ✔️ ±0  3 💤 ±0  0 ±0 
1 384 runs  ±0  1 378 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 2f6284d. ± Comparison against base commit e556bcb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 25, 2022

Unit Test Results (build & test)

521 tests   - 50   515 ✔️  - 56   14m 10s ⏱️ - 1m 32s
122 suites  - 19       0 💤 ±  0 
122 files    - 19       6 +  6 

For more details on these failures, see this check.

Results for commit 2f6284d. ± Comparison against base commit e556bcb.

This pull request removes 50 tests.
datahub.protobuf.ProtobufDatasetTest ‑ customFieldVisitors
datahub.protobuf.ProtobufDatasetTest ‑ duplicateNested
datahub.protobuf.ProtobufDatasetTest ‑ googleTimestamp
datahub.protobuf.ProtobufDatasetTest ‑ messageA
datahub.protobuf.ProtobufDatasetTest ‑ messageB
datahub.protobuf.ProtobufDatasetTest ‑ messageC
datahub.protobuf.ProtobufDatasetTest ‑ messageC2NestedOneOf
datahub.protobuf.ProtobufDatasetTest ‑ noSchemaTest
datahub.protobuf.ProtobufDatasetTest ‑ platformSchemaTest
datahub.protobuf.ProtobufUtilsTest ‑ registryTest
…

♻️ This comment has been updated with latest results.

@maggiehays maggiehays added community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata labels Aug 25, 2022
@hieunt-itfoss hieunt-itfoss changed the title feat(parser): add ability to infer schema from S3 newline JSON file feat(ingestion): add ability to infer schema from S3 newline JSON file Aug 29, 2022
@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 9, 2022

@hieunt-itfoss looks like there's a small linting error

@hieunt-itfoss hieunt-itfoss reopened this Sep 12, 2022
@github-actions github-actions bot removed the ingestion PR or Issue related to the ingestion of metadata label Sep 12, 2022
@hsheth2 hsheth2 changed the title feat(ingestion): add ability to infer schema from S3 newline JSON file feat(ingestion): schema inference for jsonlines in S3 Sep 12, 2022
@hsheth2 hsheth2 merged commit 46bc1fe into datahub-project:master Sep 12, 2022
@anshbansal anshbansal added the ingestion PR or Issue related to the ingestion of metadata label Sep 12, 2022
shirshanka pushed a commit to RyanHolstien/datahub that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Infer schema from multiline (multiple docs) JSON files
5 participants