Managing Secrets Cypress test #8863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Sep 20, 2023
| cy.waitTextVisible("Give this ingestion source a name."); | ||
| cy.get('[data-testid="source-name-input"]').type(ingestion_source_name); | ||
| cy.get("button").contains("Save").click(); | ||
| cy.waitTextVisible("Successfully created ingestion source!").wait(5000)//prevent issue with missing form data |
There was a problem hiding this comment.
what's the issue with missing form data?
jjoyce0510
reviewed
Sep 20, 2023
| cy.get("button").contains("Save").click(); | ||
| cy.waitTextVisible("Successfully created ingestion source!").wait(5000)//prevent issue with missing form data | ||
| cy.waitTextVisible(ingestion_source_name); | ||
| cy.get("button").contains("Pending...").should("be.visible"); |
There was a problem hiding this comment.
anything we can reuse here by extracting into a function?
we appear to create most of the recipe twice in same way. i leave up to you!
jjoyce0510
approved these changes
Sep 20, 2023
|
Failing with a known flaky test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test steps:
Checklist