-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): style tweaks for readability and more open spacing #8876
docs(website): style tweaks for readability and more open spacing #8876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great already - a huge improvement over our existing styles
I do feel like the sidebar has a bit too much left/right padding, but we can tweak that in a follow-up
There is a merge conflict which will need to get fixed before we can merge this
@jeffmerrick the CTAs look a bit bulky now - is this what you intended? |
@hsheth2 Ah nope must have been the high |
@jeffmerrick some additional feedback - I think it make sense to fix in this PR instead of in a follow-up The font weight on the cards feels a bit too heavy here. Also the text looks slightly misaligned with the card header text The sidebar feels too wide - I think 350px is a bit too much, and we should probably also reduce the left and right padding on the sidebar items Finally, the min left and right padding on the main content feels a bit low on smaller screens (as in the screenshot) cc @yoonhyejin - lmk if you disagree with any of this / want to tweak other things |
Generally agree with @hsheth2 , especially on the left/right padding of the main content |
No problem, made these changes:
Can you explain more what you mean on:
Alignment looks ok to me and font weight/size matches the lists that follow. |
I think previously we were going only up to semibold for font weight and now we go up to bold. (Also those are now just the default system font instead of Manrope). We can pull back the weight, here are a few options:
|
I prefer the first one here, seems much better. |
@jeffmerrick fwiw it looks like we're also using semibold for I'd say we should change the font-weight on those cards, so it looks like option 1 without changing the global bold font weight |
Yep, you're right, it's used for buttons too. I've made this change along with making the lists underneath semibold for consistency. |
Many style tweaks for readability and more open spacing. Tried to use theme variables wherever possible.
global.scss
Checklist