Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): Add preceding / to get index sizes path #9043

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix(api): Add preceding / to get index sizes path #9043

merged 1 commit into from
Oct 18, 2023

Conversation

iprentic
Copy link
Contributor

Previously, ElasticSearch would respond with a 400 bad request message.
Prepending a / to the path makes it happy

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@iprentic iprentic added the release-0.12.0 PRs targeted for Release 0.12.0 label Oct 18, 2023
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 18, 2023
@iprentic iprentic enabled auto-merge (squash) October 18, 2023 20:06
@iprentic iprentic merged commit 7855fb6 into master Oct 18, 2023
35 of 37 checks passed
@iprentic iprentic deleted the nd--get-index-sizes-path branch October 18, 2023 20:19
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@darnaut darnaut mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ product PR or Issue related to the DataHub UI/UX release-0.12.0 PRs targeted for Release 0.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iprentic @RyanHolstien @david-leifker @maggiehays