Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): skip smoke-test lint if there are no changes #9945

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 28, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Feb 28, 2024
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming that any lint failure will cause no docker builds to be triggerred. That is an intentional change to control cost + make CI experience better for all PRs

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Feb 28, 2024

@anshbansal yup that's what this does - lint is still a blocking step, but only runs if there were changes

@hsheth2 hsheth2 merged commit 55bc955 into master Feb 28, 2024
35 checks passed
@hsheth2 hsheth2 deleted the smoke-ci-lint branch February 28, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants