_save_batch() should not be a generator #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
commented
Sep 30, 2024
| @@ -35,7 +35,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| with: | |||
| ref: "deploy" | |||
| ref: "hcg/delete-fix-2" | |||
hancush
commented
Sep 30, 2024
Comment on lines
+247
to
+249
| if len(batch) > 0: | ||
| self._save_batch(batch) | ||
| n_imported += len(batch) |
There was a problem hiding this comment.
This was also missing!!! 🙀
fgregg
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change ref in workflow back to deploy before merging and deploying.
I introduced a bug by making
_save_batch()a generator. Generators are great in that they are lazy, but that's only great if you actually iterate them. 🫠 There's no reason for the save method to be a generator, so I made it a regular function instead. I also turned up the logging so we have a better idea of the record churn for future debugging endeavors.Addresses Marjorie's email.
Testing Instructions
Running on: https:/datamade/openness-project-nmid/actions/runs/11108320332