Remove pandas support #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xperiment/remove-pandas # Conflicts: # demo/personal_finance.py # requirements.txt
pskd73
commented
Apr 28, 2022
pyluca/ledger.py
Outdated
|
|
||
| def get_aging(self, account: str): | ||
| return get_account_aging(self.config, self.journal.entries, account, self.journal.entries[-1].date) | ||
|
|
||
| def add_account_balance(self, account: str, df: pd.DataFrame): | ||
| return add_account_balance(self.config, df, account) | ||
| def add_account_balance(self, account: str, ledger: List[LedgerDict]): |
There was a problem hiding this comment.
This function is not necessary. get_balance_sheet is the only function that will be exposed
pyluca/ledger.py
Outdated
| @@ -22,17 +32,27 @@ def get_account_balance(self, account: str): | |||
| return self.get_account_dr(account) - self.get_account_cr(account) | |||
| return self.get_account_cr(account) - self.get_account_dr(account) | |||
|
|
|||
| def get_df(self) -> pd.DataFrame: | |||
| return pd.DataFrame([j.__dict__ for j in self.journal.entries]) | |||
| def get_ledger(self) -> List[LedgerDict]: | |||
There was a problem hiding this comment.
ledger.get_ledger does not makes sense. Remove this function. get_balance_sheet is enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.