Do not show references for unnamed class

Fixes eclipse-jdtls#3069 Signed-off-by: David Thompson <[email protected]>
datho7561 · Feb 29, 2024 · 94a774d · 94a774d
1 parent 27a1a1e
commit 94a774d
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 4 deletions.
diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java
@@ -1854,4 +1854,8 @@ public static boolean isGenerated(IMember member) {
  return result;
  }
 
+ public static boolean isUnnamedClass(IJavaElement element) {
+ return element.getElementType() == IJavaElement.TYPE && element.getElementName().startsWith("<unnamed_class$");
+ }
+
 }
diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandler.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandler.java
@@ -212,17 +212,19 @@ private void collectCodeLenses(ITypeRoot typeRoot, IJavaElement[] elements, Coll
  }
  //ignore element if method range overlaps the type range, happens for generated bytcode, i.e. with lombok
  IJavaElement parentType = element.getAncestor(IJavaElement.TYPE);
- if (parentType != null && overlaps(((ISourceReference) parentType).getNameRange(), ((ISourceReference) element).getNameRange())) {
+ if (parentType != null && !JDTUtils.isUnnamedClass(parentType) && overlaps(((ISourceReference) parentType).getNameRange(), ((ISourceReference) element).getNameRange())) {
  continue;
  }
  } else {//neither a type nor a method, we bail
  continue;
  }
 
  if (preferenceManager.getPreferences().isReferencesCodeLensEnabled()) {
- CodeLens lens = getCodeLens(REFERENCES_TYPE, element, typeRoot);
- if (lens != null) {
- lenses.add(lens);
+ if (!JDTUtils.isUnnamedClass(element)) {
+ CodeLens lens = getCodeLens(REFERENCES_TYPE, element, typeRoot);
+ if (lens != null) {
+ lenses.add(lens);
+ }
  }
  }
  if (preferenceManager.getPreferences().isImplementationsCodeLensEnabled() && element instanceof IType type) {

diff --git a/org.eclipse.jdt.ls.tests/projects/eclipse/hello/src/UnnamedWithString.java b/org.eclipse.jdt.ls.tests/projects/eclipse/hello/src/UnnamedWithString.java
@@ -0,0 +1,7 @@
+String foo() {
+ return "foo";
+}
+
+void main() {
+ System.out.println(foo());
+}
diff --git a/...lipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandlerTest.java b/...lipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandlerTest.java
@@ -377,6 +377,27 @@ public void testIgnoreLombokCodeLensSymbols() throws Exception {
  assertRange(5, 13, 16, cl.getRange());
  }
 
+ @Test
+ public void testNoReferenceCodeLensForUnnamedClasses() throws Exception {
+ String payload = createCodeLensSymbolsRequest("src/java/UnnamedWithString.java");
+ CodeLensParams codeLensParams = getParams(payload);
+ String uri = codeLensParams.getTextDocument().getUri();
+ assertFalse(uri.isEmpty());
+ //when
+ List<CodeLens> result = handler.getCodeLensSymbols(uri, monitor);
+
+ //then
+ assertEquals("Found " + result, 2, result.size());
+
+ // CodeLens on foo()
+ CodeLens cl = result.get(0);
+ assertRange(0, 7, 10, cl.getRange());
+
+ // CodeLens on main()
+ cl = result.get(1);
+ assertRange(4, 5, 9, cl.getRange());
+ }
+
  String createCodeLensSymbolsRequest(String file) {
  URI uri = project.getFile(file).getRawLocationURI();
  return createCodeLensSymbolRequest(uri);