Do not show references for unnamed class

Fixes eclipse-jdtls#3069

Signed-off-by: David Thompson <[email protected]>

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java

@@ -1854,4 +1854,8 @@ public static boolean isGenerated(IMember member) {
  return result;
  }
 
+ public static boolean isUnnamedClass(IJavaElement element) {
+ return element.getElementType() == IJavaElement.TYPE && element.getElementName().startsWith("<unnamed_class$");
+ }
+
 }

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandler.java

@@ -212,17 +212,19 @@ private void collectCodeLenses(ITypeRoot typeRoot, IJavaElement[] elements, Coll
  }
  //ignore element if method range overlaps the type range, happens for generated bytcode, i.e. with lombok
  IJavaElement parentType = element.getAncestor(IJavaElement.TYPE);
- if (parentType != null && overlaps(((ISourceReference) parentType).getNameRange(), ((ISourceReference) element).getNameRange())) {
+ if (parentType != null && !JDTUtils.isUnnamedClass(parentType) && overlaps(((ISourceReference) parentType).getNameRange(), ((ISourceReference) element).getNameRange())) {
  continue;
  }
  } else {//neither a type nor a method, we bail
  continue;
  }
 
  if (preferenceManager.getPreferences().isReferencesCodeLensEnabled()) {
- CodeLens lens = getCodeLens(REFERENCES_TYPE, element, typeRoot);
- if (lens != null) {
- lenses.add(lens);
+ if (!JDTUtils.isUnnamedClass(element)) {
+ CodeLens lens = getCodeLens(REFERENCES_TYPE, element, typeRoot);
+ if (lens != null) {
+ lenses.add(lens);
+ }
  }
  }
  if (preferenceManager.getPreferences().isImplementationsCodeLensEnabled() && element instanceof IType type) {

org.eclipse.jdt.ls.tests/projects/eclipse/java21/src/main/java/UnnamedWithString.java

@@ -0,0 +1,7 @@
+String foo() {
+ return "foo";
+}
+
+void main() {
+ System.out.println(foo());
+}

org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandlerTest.java

@@ -118,13 +118,15 @@ public class CodeLensHandlerTest extends AbstractProjectsManagerBasedTest {
  private CodeLensHandler handler;
 
  private IProject project;
+ private IProject java21Project;
 
  private PreferenceManager preferenceManager;
 
  @Before
  public void setup() throws Exception {
- importProjects("eclipse/hello");
+ importProjects(List.of("eclipse/hello", "eclipse/java21"));
  project = WorkspaceHelper.getProject("hello");
+ java21Project = WorkspaceHelper.getProject("java21");
  preferenceManager = mock(PreferenceManager.class);
  when(preferenceManager.getPreferences()).thenReturn(new Preferences());
  handler = new CodeLensHandler(preferenceManager);
@@ -377,11 +379,39 @@ public void testIgnoreLombokCodeLensSymbols() throws Exception {
  assertRange(5, 13, 16, cl.getRange());
  }
 
+ @Test
+ public void testNoReferenceCodeLensForUnnamedClasses() throws Exception {
+ String payload = createCodeLensSymbolsRequestJava21("src/java/UnnamedWithString.java");
+ CodeLensParams codeLensParams = getParams(payload);
+ String uri = codeLensParams.getTextDocument().getUri();
+ assertFalse(uri.isEmpty());
+ //when
+ List<CodeLens> result = handler.getCodeLensSymbols(uri, monitor);
+
+ //then
+ assertEquals("Found " + result, 2, result.size());
+
+ // CodeLens on foo()
+ CodeLens cl = result.get(0);
+ assertRange(0, 7, 10, cl.getRange());
+ assertEquals("1 reference", cl.getCommand().getTitle());
+
+ // CodeLens on main()
+ cl = result.get(1);
+ assertRange(4, 5, 9, cl.getRange());
+ assertEquals("0 references", cl.getCommand().getTitle());
+ }
+
  String createCodeLensSymbolsRequest(String file) {
  URI uri = project.getFile(file).getRawLocationURI();
  return createCodeLensSymbolRequest(uri);
  }
 
+ String createCodeLensSymbolsRequestJava21(String file) {
+ URI uri = java21Project.getFile(file).getRawLocationURI();
+ return createCodeLensSymbolRequest(uri);
+ }
+
  String createCodeLensSymbolRequest(URI file) {
  String fileURI = ResourceUtils.fixURI(file);
  return CODELENS_PARAM_TEMPLATE.replace("${file}", fileURI);