forked from voraz/spreadsheet
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
13 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
164dcfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test delivers me the following error:
test_write_frozen_string(Spreadsheet::TestIntegration):
Iconv::InvalidCharacter: "g"
/home/zeno/.software/spreadsheet/lib/spreadsheet/encodings.rb:32:in
iconv' /home/zeno/.software/spreadsheet/lib/spreadsheet/encodings.rb:32:in
internal'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/biff8.rb:43:in
_unicode_string' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:509:in
_write_sst'/usr/lib/ruby/1.8/fileutils.rb:243:in
each_with_index' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:503:in
each'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:503:in
each_with_index' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:503:in
_write_sst'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:490:in
write_sst' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:440:in
write_from_scratch'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:621:in
write_workbook' /home/zeno/.software/spreadsheet/lib/spreadsheet/writer.rb:15:in
write'/home/zeno/.software/spreadsheet/lib/spreadsheet/writer.rb:14:in
open' /home/zeno/.software/spreadsheet/lib/spreadsheet/writer.rb:14:in
write'/home/zeno/.software/spreadsheet/lib/spreadsheet/workbook.rb:112:in
write' test/integration.rb:1305:in
test_write_frozen_string'Why is that?
164dcfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. For starters this is running with ruby 1.8.7, but I am not succeeding at running tests with that version. I get /home/dblock/.rvm/gems/ruby-1.8.7-p334/gems/rake-0.9.2/lib/rake/rake_test_loader.rb:11:in `require': /home/dblock/source/spreadsheet/dblock/test/suite.rb:12: undefined (?...) sequence: /(?<!suite).rb$/ (SyntaxError) or a missing ole/storage.
How do you run the tests with 1.8.7?
164dcfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping out.
With Ruby 1.9.2 on my Linux Gentoo I get:
~/.software/spreadsheet> ruby test/integration.rb
Loaded suite test/integration
Started
......................E...
Finished in 0.915108 seconds.
test_write_frozen_string(Spreadsheet::TestIntegration):
RuntimeError: can't modify frozen string
/usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/encodings.rb:11:in
force_encoding' /usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/encodings.rb:11:in
internal'/usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/biff8.rb:43:in
_unicode_string' /usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/workbook.rb:509:in
block in _write_sst'/usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/workbook.rb:503:in
each' /usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/workbook.rb:503:in
each_with_index'/usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/workbook.rb:503:in
_write_sst' /usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/workbook.rb:490:in
write_sst'/usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/workbook.rb:440:in
write_from_scratch' /usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/excel/writer/workbook.rb:621:in
write_workbook'/usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/writer.rb:15:in
block in write' /usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/writer.rb:14:in
open'/usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/writer.rb:14:in
write' /usr/lib/ruby/gems/1.9.1/gems/spreadsheet-0.6.5.8/lib/spreadsheet/workbook.rb:112:in
write'test/integration.rb:1306:in `test_write_frozen_string'
26 tests, 807 assertions, 0 failures, 1 errors, 0 skips
With Ruby 1.8.6 on my Linux Gentoo I get:
Loaded suite test/integration
Started
......................E...
Finished in 1.632229 seconds.
test_write_frozen_string(Spreadsheet::TestIntegration):
Iconv::InvalidCharacter: "g"
/home/zeno/.software/spreadsheet/lib/spreadsheet/encodings.rb:32:in
iconv' /home/zeno/.software/spreadsheet/lib/spreadsheet/encodings.rb:32:in
internal'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/biff8.rb:43:in
_unicode_string' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:509:in
_write_sst'/usr/lib/ruby/1.8/fileutils.rb:243:in
each_with_index' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:503:in
each'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:503:in
each_with_index' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:503:in
_write_sst'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:490:in
write_sst' /home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:440:in
write_from_scratch'/home/zeno/.software/spreadsheet/lib/spreadsheet/excel/writer/workbook.rb:621:in
write_workbook' /home/zeno/.software/spreadsheet/lib/spreadsheet/writer.rb:15:in
write'/home/zeno/.software/spreadsheet/lib/spreadsheet/writer.rb:14:in
open' /home/zeno/.software/spreadsheet/lib/spreadsheet/writer.rb:14:in
write'/home/zeno/.software/spreadsheet/lib/spreadsheet/workbook.rb:112:in
write' test/integration.rb:1306:in
test_write_frozen_string'BTW: The ruby-ole error seems to be connected to when you switch Ruby Versions. I get the same error, but once I close and reopen the terminal the error is gone.
Best
Zeno
164dcfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zeno, you're not using the modified source, you're using an installed gem from the previous version. It's pretty clear from error stack. If you're not convinced, look at the above code, line 11 of encodings.rb after my patch is not calling force_encoding, yet that's the error you get.
164dcfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fixed in:
http://scm.ywesee.com/?p=spreadsheet/.git;a=summary
In the testcase
string = "Frozen String.".freeze
works but
string = "Frozen String".freeze
does not work. (there is one string after 'g')
164dcfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.