Work around performance issues #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #10, performance is currently atrocious for larger objects or generally on low-powered devices. As a stop-gap until we get around to actually improve the renderer, this PR implements two measures to achieve an acceptable compromise between performance and usability: - Invisible text is now hidden during animations when only 'selectable' is activated. The reasoning is that during animation selection is not going to work reliably anyways. - If visibility is enabled and we we detect tasks that ran longer than 350ms during an OSD animation, we also hide visible text during animation to improve performance. The user is notified with a snackbar in order to reduce confusion about the disappearing text.
jbaiter
force-pushed
the
performance-workaround
branch
from
428117b
to
2d5fbe5
Compare
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 65.00% 59.22% -5.78%
==========================================
Files 10 11 +1
Lines 400 439 +39
Branches 121 130 +9
==========================================
Hits 260 260
- Misses 116 150 +34
- Partials 24 29 +5
Continue to review full report at Codecov.
|
morpheus-87
requested changes
Jul 17, 2020
jbaiter
force-pushed
the
performance-workaround
branch
from
ec2d59b
to
6a8512f
Compare
jbaiter
force-pushed
the
performance-workaround
branch
from
6a8512f
to
936a005
Compare
morpheus-87
requested changes
Jul 17, 2020
morpheus-87
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #10, performance is currently atrocious for larger objects or generally on low-powered devices. As a stop-gap until we get around to actually improve the renderer, this PR implements two measures to achieve an acceptable compromise between performance and usability: