Improve word rendering #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we'd use a word's Y-Postion and its height as the font-size in pixels. This led to a very irregular line appearance, since words consisting of all-lowercase letter would be rendered far too small. With this change, we now use the line's Y-position and height instead, making for a far more regular line appearance, with no problems for selecting text.
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 62.17% 62.17%
=======================================
Files 10 10
Lines 423 423
Branches 130 130
=======================================
Hits 263 263
Misses 134 134
Partials 26 26
Continue to review full report at Codecov.
|
morpheus-87
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd use a word's Y-Position and its height as the font-size in pixels. This led to a very irregular line appearance, since words consisting of all-lowercase letters would be rendered far too small.
With this change, we now use the line's Y-position and height instead, making for a far more regular line appearance, with no problems for selecting text.
