Fix hOCR end-of-line whitespace handling #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 70.25% 70.24% -0.02%
==========================================
Files 11 11
Lines 659 662 +3
Branches 198 199 +1
==========================================
+ Hits 463 465 +2
- Misses 165 166 +1
Partials 31 31
Continue to review full report at Codecov.
|
hOCR lines that don't end on hyphenation now end correctly with a newline character in their last span's text. Additionally, this commit improves whitespace rendering by setting the CSS `white-space` option to `pre`. This removes the ugly gaps between text-spans when selecting text.
stefan-it
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hOCR lines that don't end on hyphenation now end correctly with a newline character in their last span's text.
Additionally, this commit improves whitespace rendering by setting the CSS
white-spaceoption topre. This removes the ugly gaps between text-spans when selecting text.