Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2437] [Bug] Fix when the release test branch gets bumped #92

Open
Tracked by #87
emmyoop opened this issue Apr 19, 2023 · 0 comments
Open
Tracked by #87

[CT-2437] [Bug] Fix when the release test branch gets bumped #92

emmyoop opened this issue Apr 19, 2023 · 0 comments
Assignees
Labels
bug Something isn't working tech_debt

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 19, 2023

Current State

The *.latest branch gets cut when we are ready to release the first rc with the cut-release-branch.yml action. Currently, this action also bumps the branch to test releases off here.

Problem

The problem is that an rc is not a final release so when the nightly adapter release tests runs, it cannot find the correct version of core and fails.

Possible Solutions

This is a first pass and definitely needs more thought.

  1. Completely remove the step to bump this and do it manually. Not ideal because we will forget.
  2. Somehow make the action smart enough to figure out what the latest is and programmatically determine what branch we should run off. More ideal but I'm not sure how complex this would be.
  3. Remove bumping the latest from cut-release-branch.yml and do it as part of the release when we're doing the first final release. This seems a bit unintuitive that it will happen.
  4. Allow the release-test to use pre-release versions. Will involve figuring out why this step doesn't return the pre-release with the version. Most ideal

Additional Information

dbt-core runs against main so this is not an issue for that repo. This only affects the adapters. Each adapter has a custom update_release_branch.sh script.

dbt-spark does not currently have a release test

dbt-bigquery did not get this bumped and therefore did not break. But that also means it never gets bumped automatically and must be done manually.

@emmyoop emmyoop added bug Something isn't working internal_tooling labels Apr 19, 2023
@github-actions github-actions bot changed the title [Bug] Fix when the release test branch gets bumped [CT-2437] [Bug] Fix when the release test branch gets bumped Apr 19, 2023
@mikealfare mikealfare self-assigned this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech_debt
Projects
None yet
Development

No branches or pull requests

2 participants