Add github/release/create action
#198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
reviewed
May 16, 2024
| echo is-draft : ${{ inputs.is-draft }} | ||
|
|
||
| - name: "Download release artifacts from `${{ inputs.archive-name }}`" | ||
| if: ${{ !(inputs.archive-name == '') }} |
There was a problem hiding this comment.
Why would we continue when we have no artifacts?
| - name: "Set release inputs" | ||
| id: release | ||
| shell: bash | ||
| run: ./github/release/create/set_release_inputs.sh |
There was a problem hiding this comment.
Another place where the logic is simple but is hidden by putting it into another file. The fact that the env vars are somewhat complex to define make it ever harder to follow what's happening because of the logic split into two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a new GitHub release.
Checklist