Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro to allow adapter-specific choice of unspecified value #263

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

steffen030
Copy link

@steffen030 steffen030 commented Jul 15, 2024

The current implementation of unit tests renders null values for unspecified columns. This however is problematic for databases like Clickhouse which know not-nullable datatypes. For these cases unit tests are currently not working.

This PR allows database adapters to override the unspecified column value.

It closes dbt-labs/dbt-core#10447

@steffen030 steffen030 requested a review from a team as a code owner July 15, 2024 18:50
Copy link

cla-bot bot commented Jul 15, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @steffen030

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

cla-bot bot commented Jul 15, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @steffen030

@steffen030
Copy link
Author

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @steffen030

Should be signed now.

@cla-bot cla-bot bot added the cla:yes label Jul 17, 2024
@colin-rogers-dbt colin-rogers-dbt added the community This PR is from a community member label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow adapters to override unspecified values in unit tests
2 participants