Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add the ability to specify a quota project in the bq connection profile #1343

Open
3 tasks done
jcarpenter12 opened this issue Sep 11, 2024 · 0 comments · May be fixed by #1345
Open
3 tasks done

[Feature] Add the ability to specify a quota project in the bq connection profile #1343

jcarpenter12 opened this issue Sep 11, 2024 · 0 comments · May be fixed by #1345
Labels
cost_reduction enhancement New feature or request

Comments

@jcarpenter12
Copy link

jcarpenter12 commented Sep 11, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-bigquery functionality, rather than a Big Idea better suited to a discussion

Describe the feature

I want the ability to specify a GCP quota_project on top of the existing project and execution_project in the dbt profile as an optional parameter. The reason for this being that this allows the user to specify which quota project to use when submitting a query, rather than it using the default quota_project of the user/service account. Please see this bug for details on the issue #1347

This will mean users can set a quota project of their choosing independent of where they execute the query from

GCP docs overview of Quota Projects here

Describe alternatives you've considered

As the quota project is not set by the dbt adapter now when it sets up the client the only way around this is to ensure whatever account you are using has been setup in the quota project you intend to use so it defaults to it. This is the reason I spotted this. #1347

Who will this benefit?

This will benefit anyone who wants to override the default quota project when running their dbt models. Also, it will fix a bug that currently blocks users using accounts which have been setup in projects that do not have the BQ API enabled as outlined in this bug issue #1347

Are you interested in contributing this feature?

Yes I am. I have made the changes on a feature branch but will require some guidance on the approach I have taken

PR for potential fix here #1345

Anything else?

I have not contributed to something like this before and there will almost certainly be something I have missed or misunderstood. I have done my best to follow everything outlined in the contributing guide but please do not hold back if there's something that needs to be called out. I will not be offended as it will only help my understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cost_reduction enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants