Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable overriding the dataproc project for python models #1365

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

enable overriding the dataproc project for python models #1365

wants to merge 3 commits into from

Conversation

matt-winkler
Copy link
Contributor

resolves #1364
docs dbt-labs/docs.getdbt.com/#

Problem

Currently, dbt-bigquery does not support overriding the execution_project for python models. Adding this will enable users to better balance their compute allocations at scale.

Solution

Includes logic to enable setting a dataproc_project configuration. Otherwise just use execution_project

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@matt-winkler
Copy link
Contributor Author

@dbt-labs/adapters Hi Team, looking for philosophical comment on this ahead of doing additional testing. Thank you!

@colin-rogers-dbt
Copy link
Contributor

@matt-winkler no philosophical qualms on this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support Optional Override of dataproc cluster for python models
2 participants
@matt-winkler @colin-rogers-dbt