Add Behavior Flag Framework #183
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
| @@ -140,6 +141,7 @@ show_error_codes = true | |||
| disable_error_code = "attr-defined" # TODO: revisit once other mypy errors resolved | |||
| disallow_untyped_defs = false # TODO: add type annotations everywhere | |||
| warn_redundant_casts = true | |||
| ignore_missing_imports = true | |||
There was a problem hiding this comment.
mypy was looking for pytest_mock types.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 64.45% 65.08% +0.63%
==========================================
Files 51 52 +1
Lines 3249 3325 +76
==========================================
+ Hits 2094 2164 +70
- Misses 1155 1161 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -1 +1 @@ | |||
| version = "1.7.0" | |||
| version = "1.8.0a1" | |||
There was a problem hiding this comment.
If I don't do this, hatch will not install this branch when testing in dbt-adapters since the version on this branch matches what's in PyPI. This will become 1.8.0 at some point so this feels right.
| ] | ||
| per-file-ignores = ["*/__init__.py: F401"] | ||
| per-file-ignores = ["*/__init__.py: F401", "*/conftest.py: F401"] |
There was a problem hiding this comment.
pytest fixtures get registered by importing them into conftest.py. They do not need to be used in that file.
|
Looks good. |
resolves #178
Description
Add Behavior Flag Framework to
dbt-commonin alignment with RFC-78.Checklist
changie newto create a changelog entry