Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
remove incorrect comment
fix an issue where we looked deps up by the wrong key
  • Loading branch information
Jacob Beck committed May 8, 2019
1 parent 3af88b0 commit 905bdbc
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions core/dbt/task/deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ class GitPackage(Package):

def __init__(self, *args, **kwargs):
super(GitPackage, self).__init__(*args, **kwargs)
# strip trailing '.git's from urls
self._checkout_name = hashlib.md5(six.b(self.git)).hexdigest()
self.version = self._contents.get('revision')

Expand Down Expand Up @@ -520,16 +519,16 @@ def run(self):

while pending_deps:
sub_deps = PackageListing.create([])
for name, package in pending_deps.items():
for package in pending_deps.values():
final_deps.incorporate(package)
final_deps[name].resolve_version()
target_config = final_deps[name].fetch_metadata(self.config)
final_deps[package].resolve_version()
target_config = final_deps[package].fetch_metadata(self.config)
sub_deps.incorporate_from_yaml(target_config.packages)
pending_deps = sub_deps

self._check_for_duplicate_project_names(final_deps)

for _, package in final_deps.items():
for package in final_deps.values():
logger.info('Installing %s', package)
package.install(self.config)
logger.info(' Installed from %s\n', package.nice_version_name())
Expand Down

0 comments on commit 905bdbc

Please sign in to comment.