Merge pull request #2958 from fishtown-analytics/fix/keyerror-defer-m…

…issing-parent

Fix KeyError from defer + deletion

CHANGELOG.md

@@ -20,6 +20,7 @@
 - Allow docs blocks in exposure descriptions ([#2913](https:/fishtown-analytics/dbt/issues/2913), [#2920](https:/fishtown-analytics/dbt/pull/2920))
 - Use original file path instead of absolute path as checksum for big seeds ([#2927](https:/fishtown-analytics/dbt/issues/2927), [#2939](https:/fishtown-analytics/dbt/pull/2939))
 - Defer if and only if upstream reference does not exist in current environment namespace ([#2909](https:/fishtown-analytics/dbt/issues/2909), [#2946](https:/fishtown-analytics/dbt/pull/2946))
+- Fix KeyError if deferring to a manifest with a since-deleted source, ephemeral model, or test ([#2875](https:/fishtown-analytics/dbt/issues/2875), [#2958](https:/fishtown-analytics/dbt/pull/2958))
 
 ### Under the hood
 - Bump hologram version to 0.0.11. Add scripts/dtr.py ([#2888](https:/fishtown-analytics/dbt/issues/2840),[#2889](https:/fishtown-analytics/dbt/pull/2889))

core/dbt/contracts/graph/manifest.py

@@ -234,7 +234,8 @@ def build_edges(nodes: List[ManifestNode]):
  for node in nodes:
  backward_edges[node.unique_id] = node.depends_on_nodes[:]
  for unique_id in node.depends_on_nodes:
- forward_edges[unique_id].append(node.unique_id)
+ if unique_id in forward_edges.keys():
+ forward_edges[unique_id].append(node.unique_id)
  return _sort_values(forward_edges), _sort_values(backward_edges)
 
 

test/integration/062_defer_state_test/changed_models_missing/schema.yml

@@ -0,0 +1,9 @@
+version: 2
+models:
+ - name: view_model
+ columns:
+ - name: id
+ tests:
+ - unique
+ - not_null
+ - name: name

test/integration/062_defer_state_test/changed_models_missing/table_model.sql

@@ -0,0 +1,2 @@
+{{ config(materialized='table') }}
+select 1 as fun

test/integration/062_defer_state_test/changed_models_missing/view_model.sql

@@ -0,0 +1 @@
+select * from {{ ref('seed') }}

test/integration/062_defer_state_test/test_defer_state.py

@@ -119,6 +119,23 @@ def run_defer_iff_not_exists(self):
  # because the seed now exists in our schema, we shouldn't defer it
  assert self.other_schema not in results[0].node.compiled_sql
  assert self.unique_schema() in results[0].node.compiled_sql
+
+ def run_defer_deleted_upstream(self):
+ results = self.run_dbt(['seed'])
+ assert len(results) == 1
+ results = self.run_dbt(['run'])
+ assert len(results) == 2
+
+ # copy files over from the happy times when we had a good target
+ self.copy_state()
+
+ self.use_default_project({'source-paths': ['changed_models_missing']})
+ # ephemeral_model is now gone. previously this caused a 
+ # keyerror (dbt#2875), now it should pass
+ self.run_dbt(
+ ['run', '-m', 'view_model', '--state', 'state', '--defer', '--target', 'otherschema'],
+ expect_pass=True,
+ )
 
  @use_profile('postgres')
  def test_postgres_state_changetarget(self):
@@ -142,6 +159,10 @@ def test_postgres_state_changedir(self):
  @use_profile('postgres')
  def test_postgres_state_defer_iffnotexists(self):
  self.run_defer_iff_not_exists()
+
+ @use_profile('postgres')
+ def test_postgres_state_defer_deleted_upstream(self):
+ self.run_defer_deleted_upstream() 
 
  @use_profile('snowflake')
  def test_snowflake_state_changetarget(self):